Revert "only renderBody when view is visible/expanded (#165187)" #168853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8f06fd3.
|
Extensions view assumes that the list is created (in renderBody) already when the view is shown even when collapsed. View also has a badge that shows number of extensions. It needs some changes to adopt to the lazy rendering body change. Hence I have reverted this change assuming that it will not have behavioural impact on other views. It is the safe fix I can think of for fixing this. |
joaomoreno
approved these changes
Dec 12, 2022
sbatten
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8f06fd3.
Fixes #168703