Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of common/diagnostics #54486

Closed
jrieken opened this issue Jul 17, 2018 · 2 comments
Closed

Remove usages of common/diagnostics #54486

jrieken opened this issue Jul 17, 2018 · 2 comments
Assignees
@bpasero @isidorn
Labels
debt Code quality issues
Milestone
July 2018

Comments

@jrieken
Copy link
Member

jrieken commented Jul 17, 2018

There is base/common/diagnostics.ts which isn't used much anymore and also off by default (requires code change to be enabled). This util shouldn't be used anymore as we now have a solid logging story. Please stop using it and delete it then.
@jrieken jrieken changed the title Remote usage of common/diagnostics Remove usages of common/diagnostics Jul 17, 2018
@jrieken jrieken added the debt Code quality issues label Jul 17, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 18, 2018

@bpasero I have removed the diagnostics.ts and am now instead using logService.info
The only actual change will be in textFileEditorModel so check that out once you have a chance

@isidorn isidorn added this to the July 2018 milestone Jul 18, 2018
isidorn added a commit that referenced this issue Jul 18, 2018
@isidorn
Properly remove diagnostics.ts
d03af90 
fixes #54486
@bpasero
Copy link
Member

bpasero commented Aug 6, 2018

@isidorn thanks LGTM

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@isidorn isidorn

Labels
debt Code quality issues
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
3 participants
@bpasero @jrieken @isidorn