Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding extension host shut down on opening folder #75720

Closed
jumattos opened this issue Jun 18, 2019 · 10 comments
Closed

Avoiding extension host shut down on opening folder #75720

jumattos opened this issue Jun 18, 2019 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@jumattos
Copy link
Member

jumattos commented Jun 18, 2019

I am working on a VS code extension that shows remote files. We invoke the openFolder command using our own file system provider (powered by the cloud).

The problem is that the command shuts down the extension host process. VS Code then can't find our file system provider, and the file explorer is not loaded correctly. If the user waits a couple of seconds and collapse/expand the file explorer view, the files show up as expected.

Right now, we simply reload the file explorer once the extension is up and running again. This is not ideal, since it takes quite a bit of time and doesn't prevent the failure from happening.

// The next line ensures the file explorer will be loaded correctly
vscode.commands.executeCommand('workbench.files.action.refreshFilesExplorer');

How can we work around this? Could we have the option of opening a folder without shutting down the extension host?

@isidorn
Copy link
Contributor

isidorn commented Jun 19, 2019

@jumattos on what activation events does your extension activate? Is your extension open source if yes can you please give a pointer to the GitHub repository.
Extension host shuting down when we open a new folder is designed behavior. Right @bpasero ?
The issue here it seems is that your extension is not ready early enough when the explorer tries to resolve files.

Are you opening a folder which has a Scheme which is tied to your file system provider?

Can you provide reproducable steps using your extension?

@isidorn isidorn added file-explorer Explorer widget issues info-needed Issue requires more information from poster labels Jun 19, 2019
@bpasero
Copy link
Member

bpasero commented Jun 19, 2019

@isidorn when a folder is opened, the following process are going down and restart:

  • renderer process
  • extension host process
  • any spawned process (such as file watcher, search).

You can try this out easily by:

  • open VSCode
  • hit the reload command (Cmd+R)
  • processes will go down and restart

@jumattos
Copy link
Member Author

On what activation events does your extension activate?

"activationEvents": [
    "*"
],

Is your extension open source if yes can you please give a pointer to the GitHub repository.

Not open source, unfortunately, but I can share with Microsoft employees if needed.

Are you opening a folder which has a Scheme which is tied to your file system provider?

Yes. We have a RemoteFileProvider which implements vscode.FileSystemProvider.

@jumattos
Copy link
Member Author

Since our extension loads on startup already, I don't see a way of having it ready when the explorer tries to resolve the files. Any suggestions?

@isidorn
Copy link
Contributor

isidorn commented Jun 20, 2019

@jumattos What is your extension and what are the exact steps to reproduce this?
So I can try this on my machine and see what is going on.

Also your extensions shuold be ready since you activate on "*", so when the explorer tries to resolve the files your FileSystemProvider should be registered. Now I need your extension and steps to confirm all of this. If this is not possible I can give you code pointers so you do some debugging. Let me know what works better for you

@jumattos
Copy link
Member Author

What is your extension and what are the exact steps to reproduce this?

Our extension is not yet released (we are on private preview + dogfooding). I will send you a link privately, please refrain from sharing.

Yesterday my team and I digged around a little further and found that the extension works on version 1.33.1 of VS Code, but not on the latest version.

Steps to reproduce:

  1. Clone a repository that is set up for our extension (e.g. spring-petclinic)
  2. Open the folder on VS Code
  3. Go to the GitHub Pull Requests extension
  4. Sign in to GitHub
  5. Open "All" to see all pull requests open
  6. Right click the only pull request available
  7. Choose "View Remote Files"
  8. You will be prompted to login to our extension (let me know if you have any trouble during that step)
  9. You will be taken to the Remove Files view. The file explorer will not load correctly
  10. Collapse/expand the file explorer after a couple of seconds. That should be enough to trigger refresh, and the files will show up as expected

@isidorn
Copy link
Contributor

isidorn commented Jun 21, 2019

@jumattos thanks for the repro steps.
I have pushed a potential fix for your issue, however I could not verify that it fixes it since I can not log in. If you want to verify it works just run vscode out of source and try it out (just copy over your extension and the gh pr extension to your user dir /.vscode-oss-dev/extensions).
https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run
Or you can wait for monday until we release a new insiders which will have the fix

As for the login issue I have pinged you on Teams for more details.

In case you want to investigate more on our side, here are some code pointers and tips:
F1 > developer tools > sources > put a brekapoint here
Try to figure out if the onDidChangeFileSystemProviderRegistrations is fired as expected and if the recursive refresh is fired
The code is not that complex. Basically when a new file system provide is regsitered (which should be the case for you) we should refresh the whole tree by firing an event from the explorerService.
That event is handled here. And it should recursivly refresh the whole tree.

kiku-jw added a commit to kiku-jw/vscode that referenced this issue Jun 26, 2019
* beautify macos keyboard layout label

* Open folders and workspaces in new windows

* Basic file opening via Open File command

* Update auto detect layout info.

* Respect openFoldersInNewWindow setting for folders/workspaces

* Make openWindow function resolve at right time

* keyboard layout status bar item tooltip

* Move workspace menu and action to fileActions.contribution

* Add clarifying comment on instance service request events

* Fullscreen change event.

* Remove unneeded margin on settings editor scrollbar
Fix microsoft#75724

* fix: microsoft#72626

* Remove extra register of automatic tasks

Fixes microsoft#75758

* remove trailing '/' from repo url for baseFolderName

* handle style-attribute modifications, cache requests in addition to results, microsoft#75061

* fix microsoft#75818

* fix bad tree guide indentation

* remove TODO

* update eslint

* update distro

fixes microsoft#73872

* Revert "Revert "Merge pull request microsoft#75695 from orange4glace/master""

This reverts commit a05e05c.

* Revert "Revert "explorero: file actions disablment no longer needed""

This reverts commit b634152.

* more code insets API tweaks, microsoft#66418

* Alpine build

* Update distro hash

* Remove duplicate cp

* shellscript: Add folding markers

* fixes microsoft#75829

* show setting on windows only

* add ExtensionKind and remoteName propsed APIs, microsoft#74188

* debt - use file service based configuration file service

* fix tests

* debt create configuration file service inside configuration service

* First cut of file service based user data service

* Use user data service for reading settings

* Update distro hash

* add diagnostic tool for git file event issues

* 💄

* Update distro hash

* introduce VSCODE_STEP_ON_IT

* remove env scripts

fixes microsoft#74792

* Update xterm.css

Fixes microsoft#75827

* check if file exists

* remove alert, aria-live will read the content even with no focus

fixes microsoft#41356

* win code.sh fix

* 🧀 Fix microsoft#75831

* Add proposed api check for shell API

Part of microsoft#75091

* launch ext host window internally

* EH debugging: support multiple files and folders

* Update distro

* xterm@3.15.0-beta50

Diff: xtermjs/xterm.js@846a189...96eafd3

Changes:

- Publish improvements
- Layering/strict updates

* Fire onDidChangeMaximumDimension when dimensions are set

Fixes microsoft#73496

* Fix potential race

* Delete cached service worker entries after a short timeout

* Fix webview developer command not being registered

* Re-queue canceled geterr requests before remaining buffers

We should give higher priority to files that have previously had geterr triggered on them but did not have their request completed

* Remove log uploader

Fixes microsoft#75748

* Use localized name for macOS keyboard layout

* fixes microsoft#75856

* User keyboard layout

* simplify common keymap layer

* load user keyboard layout after initialization

* US Standard keyboard info

* better score for layout

* fast return keyboard layout if 48-keymap matches

* a single keyboard event can be a keymap

* switch to user selected keyboard layout

* Have `.get` return promise directly

* Make sure we wait until service worker is ready before creating content

* Add version check to service worker

Try to make sure our page is talking to the expected version of the service worker

* Don't use clone as much

* Move host javascript to own file

* Update distro

* Remove icon explorations before shipping stable

* Move listener to window service.

* Minimap: Render find match decorations, fixes microsoft#75216

* Fix `navigator.serviceWorker.ready` is a Promise, not a function

* Use update instead of manually tring to re-register

* Extract ITypeScript server interface

* extract server error to own file

* Extract server spanwer to own file

* Renames

* Move getQueueingType into class

* Add experimental dual TS server

Fixes microsoft#75866

* Enable "typescript.experimental.useSeparateSyntaxServer" for VS Code workspace

* Remove trailing comma

* Include server id in TS server errors

* Make execute command a configuration object

* Also include format in the syntax commands

* Fix method name

* Renames

* Better encapsulate logic of spawning different server kinds

* some fixes for mac web

* New test runner API for microsoft#74555

* update doc, microsoft#74188

* build: release only iff all builds succeed, introduce VSCODE_RELEASE env

* first version of vscode.workspace.fs

* 💄

* Tasks registration + the local ext host now has an autority

Part of microsoft/vscode-remote-release#757

* Add platform override to getDefaultShellAndArgs in terminal

Part of microsoft/vscode-remote-release#757

* Ensure no trailing path separtor on URIs from file picker

Part of microsoft#75847

* data tree view state should store scrollTop, microsoft#74410

* fix microsoft#75564

* Change promise structure of creating terminal in tasks

Potential fix for microsoft#75774

* do not allow additionalProperties

microsoft#75887

* explorer: roots forget children on new file system provider registration

microsoft#75720

* Update max tokenization limit without reload

* Use interfaces for keyboard layout registration

* Separate keyboard layout loading logic for testing

* Test browser keymapper

* unused standard keyboard event.

* Make sure we dismiss the zoom status bar entry when switching editors

* Reduce state

* Added strictly typed telemetry function (microsoft#75915)

* Added strictly typed telemetry function

* cleanup publicLog2 signature

* Extract port mapping helper function

* Re-use extractLocalHostUriMetaDataForPortMapping for openUri

* Also map 127.0.0.1 in webviews and forward it for openExternal

Fixes microsoft/vscode-remote-release#108

* use empty model when content is empty

* 💄

* Update keyboard layout file comments

* Delete breadcrumbs.filterOnType unused setting. Fixes microsoft#75969

* Add quick open/input color registrations (fixes microsoft#65153)

* Update API

* implements ExtHostEditorInsetsShape

* use divs for tree indent guides

fixes microsoft#75779

* comment out more (for microsoft#74898)

* Quick Open > Quick Input (microsoft#65153)

* build - enable language server tests again (for microsoft#74898)

* use polish for wsl1

* move extension kind to Extension-interface

* init log level of remote log service

* Open/Save local commands should not show in the command palette

Fixes microsoft#75737

* chockidar: use polling

* fix build conditions

* xterm fixes for cglicenses

* oss 1.36.0

* workaround for microsoft#75830

* update distro commit

* electron - still call setBounds() as workaround for first window

* fixes microsoft#75753

* node-debug@1.35.3

* remove user data service

* use posix.join

* update doc

* Add -1 tab index to status bar entries

This keeps them out of the tab order, but allows them to be read with a screen reader

Fixes microsoft#41406

* empty view polish labels for remote case

microsoft/vscode-remote-release#511

* send remote watcher error to file service (fixes microsoft/vscode-remote-release#329)

* update distro

* better error handling in case of loader error in tests

* fix win 32 bits unit tests

* electron@4.2.5 (microsoft#76020)

* Code-insiders started from WSL doesn't return to console/ doesn't connect. Fixes microsoft/vscode-remote-release#780

* Group decorations by line before rendering

* disable support for simple fullscreen (microsoft#75054)

* telemetry - add window.nativeFullScreen

* move API to stable,  microsoft#74188

* build - add and use --disable-inspect for integration tests (microsoft#74898)

* 💄

* bump distro

* Report workspace stats in shared process

* Make return undefined explicit

* Add missing return

* Use explicit window.createWebviewManager

* gdpr comments

* webkit fullscreen detection

* Fix file name spelling

* update distro

* add logging

* disabling installing extension from gallery when not enabled

* status.workbench.keyboardLayout

* Move Inspect Keyboard Layout JSON to workbench

* return local extension after install

* install deps and packs while installing from gallery

* Fix default shell selector outside of Windows

Fixes microsoft#76040

* Add explicit win32 gheck for using user specific temp folder

* Always use settings UI when querying online services, fixes microsoft#75542

* Disable conpty in terminal when accessibility mode is on

Fixes microsoft#76043

* Move the webviewResourceRoot property to be set on each webview instead of as a global property

For microsoft#72155

This allows  us to potentially change the resource root per webview

* Make RelativeWorkspacePathResolver  a static class

* Use openExternal

* Auto restart when changing  typescript.experimental.useSeparateSyntaxServer

* Fix regular expression for rewriting iframe webview html replacing quotes

* Telemetry Command (microsoft#76029)

* Added telemetry command

* Initial Build support

* Added build logic for telemetry

* Linux Builds

* Windows builds sort of work

* Remove arm telemetry extraction

* Remove alpine telemetry extraction

* Remove accidental s

* More try catch

* Use full resource uri for transforming webview resources

This ensures we still work even if there is no base uri set

* Use outerHtml to make sure we write `<html>` element from extensions too

* Use a regexp that works across browsers

* Implement reload on iframe based webview Elements

* fix various nls issues

* 💄

* add debug output (microsoft#76024)

* Fix tasks platform for quoting

Fixes microsoft#75774

* fix hockeyapp symbols and report errors (fix microsoft#76024)

* update distro

* fix bad watch

* update distro

* Fix drive letter casing on typescript tasks

Occurs when opening by double clicking on workspace file. Fixes microsoft#75084

* update distro

* update distro

* Test remoteName and extensionKind (for microsoft#76028)

* MainThreadFileSystem does not await

* Fix microsoft#76096

* Rename runInBackground to hideFromUser

See microsoft#75278

* Update distro

* Fix minimap decoration rendering on horizontal scroll, fixes microsoft#76128

* Handle windows paths correctly when loading webvie resources

* Fix standard link handler for iframe based webviews

* Mark extensions.all as readonly

This iteration, we marked a few other arrays as readonly. We should do the same for extensions.all

* Fix microsoft#75927.

* Register mouse down on container dom node.

* Make sure we never cancel a request to just one of the ts servers

Fixes microsoft#76143

* Show document link tooltip first and put click instructions in parens

Fixes microsoft#76077

This change also update our standard link hovers to follow this format

* reset listener once users choose a dedicated keyboard layout

* switch to a new layout only when the score is higher.

* Fix kb unit test

* fix microsoft#76149

* web - document some API

* 💄 workbench API

* disable arm and alpine for stable

fixes microsoft#76159

* Fix extra auto complete on fast delete (microsoft#74675)

Fixes #vscode-remote-release/4

* use yarn --frozen-lockfile for builds

* remove `update.enableWindowsBackgroundUpdates` from online settings

* fix microsoft#76076

* revert the change

* prevent product.json containing gallery

* fix microsoft#76074

* fixes microsoft#54084

* Fix microsoft#76105

* fix microsoft#75904

* workaround for  microsoft#74934
@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2019

I am closing this since I pushed a fix.
Please let me know if you still see this and I can reopen this issue.

@isidorn isidorn closed this as completed Jun 26, 2019
@jumattos
Copy link
Member Author

Sorry for the late reply. The fix seems to have worked for most of our use cases. The ones that are not working right now probably have some other cause that I will have to investigate. Thanks for your help! 😊

@isidorn
Copy link
Contributor

isidorn commented Jun 27, 2019

Thanks for letting me know. Adding verified label.
Once you find the other cases with repro steps please open a new issue and ping me on it - thank you very much.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded and removed info-needed Issue requires more information from poster labels Jun 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants