Adopt terminal link provider API

[jmbockhorst]

This adopts the new xterm.js link provider API and uses VS Code's shared link detection system. Added a new setting terminal.integrated.experimentalLinkProvider to control this behavior. Closes #90298.

Also, it was very complicated figuring out what was 0-based or 1-based and what to use where, so hopefully that can be cleared up with xtermjs/xterm.js#2706.

[jmbockhorst]

I reverted the old changes and pushed a new solution that doesn't modify LinkComputer and still works as before. I used part of your idea so that the adapter handles the wrapped lines.

[Tyriar]

Merged in so xterm is on latest: b4c19fd

[jmbockhorst]

I updated the branch and fixed the issues with widget hovering so that it works reliably.

[Tyriar]

@jmbockhorst thanks and sorry about the delay, I was busy in the week I would try to merge (debt week) due to launching settings sync. Hopefully I'll finish this iteration's work early or get to it early April. I haven't forgotten 😃

[Tyriar]

I merged from master and did my best to fix the conflicts but I'm seeing the activation not happen when cmd+clicking (tested on mac). See the activate logs in the gif below, the first one worked but the other 3 didn't:

The reason was because _currentLink was undefined here:

https://github.com/xtermjs/xterm.js/blob/e2ac4b45d0747ae3d6ab3eb1e3ba9be7cbdec351/src/browser/Linkifier2.ts#L129

I also notice the link seems to get disposed when you click it, or just the rendering part of it anyway. We definitely want to keep the underline when clicked.

[Tyriar]

It could be related to this new feature if this wasn't happening before:

vscode/src/vs/workbench/contrib/terminal/browser/terminalLinkHandler.ts

Lines 254 to 275 in 433380c

	// Allow the link to be intercepted if there are listeners
	if (this._hasBeforeHandleLinkListeners) {
	const wasHandled = await new Promise<boolean>(r => {
	const timeoutId = setTimeout(() => {
	canceled = true;
	this._logService.error(`An extension intecepted a terminal link but it timed out after ${TerminalLinkHandler.LINK_INTERCEPT_THRESHOLD / 1000} seconds`);
	r(false);
	}, TerminalLinkHandler.LINK_INTERCEPT_THRESHOLD);
	let canceled = false;
	const resolve = (handled: boolean) => {
	if (!canceled) {
	clearTimeout(timeoutId);
	r(handled);
	}
	};
	this._onBeforeHandleLink.fire({ link, resolve });
	});
	if (!wasHandled) {
	handler(link);
	}
	return;
	}

[Tyriar]

Also can't seem to repro this in xterm.js' demo so not sure what's going on.

[Tyriar]

Ah I figured it out, "terminal.integrated.rendererType": "experimentalWebgl" does another renderer which clears the current link.

[Tyriar]

Created xtermjs/xterm.js#2836

[jmbockhorst]

Are there still problems with link activation in the other renderers?

[Tyriar]

@jmbockhorst just webgl, will update vscode's xterm with the fix to xtermjs/xterm.js#2836 soon

[Tyriar]

Ok that seems to have fixed it 🎉

[Tyriar]

Made some changes to cover wide characters including edge cases like this:

It beats out old link matchers in this respect now:

[Tyriar]

CI passed, merging. Thanks a lot for all the work here @jmbockhorst, this is much better than it was for web links, just need to close the functionality gap and we should be good to switch this over.

[jmbockhorst]

Thank you for all of the help and guidance along the way!