Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link providers don't work when the webgl addon is enabled #2836

Closed
Tyriar opened this issue Apr 11, 2020 · 1 comment · Fixed by #2837
Closed

Link providers don't work when the webgl addon is enabled #2836

Tyriar opened this issue Apr 11, 2020 · 1 comment · Fixed by #2837
Assignees
@Tyriar
Labels
area/addon/webgl area/links type/bug Something is misbehaving
Milestone
4.6.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 11, 2020 •
edited

Webgl does a render when clicking which causes links to sometimes clear the current link before the click/activate event fires.

See microsoft/vscode#90336 (comment)
@Tyriar Tyriar added this to the 4.6.0 milestone Apr 11, 2020
@Tyriar Tyriar self-assigned this Apr 11, 2020
@Tyriar Tyriar mentioned this issue Apr 11, 2020
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Apr 11, 2020

Probably related to webgl needing to re-render when selection changes unlike the other renderers.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 11, 2020
@Tyriar
Only fire IRenderService.onRender when buffer changes occurred
55f9203 
Fixes xtermjs#2836
@Tyriar Tyriar mentioned this issue Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/webgl area/links type/bug Something is misbehaving
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

Only fire IRenderService.onRender when buffer changes occurred Tyriar/xterm.js
1 participant
@Tyriar