Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent VS Test Explorer integration of Code Coverage for .NET Framework and .NET Core #852

Closed
pvlakshm opened this issue Jun 12, 2017 · 3 comments

Comments

@pvlakshm
Copy link
Contributor

For .NET Framework projects, the code coverage context menu command from the Test Explorer just works.
However for .NET Core projects, it works ONLY if the project has a NuGet reference to “Microsoft CodeCoverage”. If not, then the context menu item silently does nothing.

Several options:
(1) Give an error dialog and point to the help page that tells the user to add the reference.
(2) Do not enable the command unless the test project is appropriately configured.
(3) Have the command add the reference to the test project(s).
(4) Have the .NET Core test project template already have a reference to the NuGet package. This would make the behaviour consistent.

I suggest (4).

@terrajobst
Copy link
Member

terrajobst commented Jun 12, 2017

I don't think (2) is the right choice as it's just masking the problem making it equally hard for customers to find out what's wrong. I think a combination of (4) and (3) would be ideal.

@codito codito added the exp: ide label Jul 7, 2017
@codito codito added this to the 15.5 milestone Jul 7, 2017
@codito
Copy link
Contributor

codito commented Jul 7, 2017

Adding all coverage impacting issues for 15.5.

@harshjain2
Copy link
Contributor

@pvlakshm @terrajobst Thanks for providing feedback.
I have fixed this issue through approach (4) in #1020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants