Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't build with Clang for x86 Debug #7

Closed
dunhor opened this issue Apr 27, 2019 · 3 comments · Fixed by #41
Closed

Tests don't build with Clang for x86 Debug #7

dunhor opened this issue Apr 27, 2019 · 3 comments · Fixed by #41
Labels
bug Something isn't working clang Bugs or behavioral issues that are specific to Clang help wanted Extra attention is needed

Comments

@dunhor
Copy link
Member

dunhor commented Apr 27, 2019

This is likely a Clang/linker bug, but needs to be looked at more closesly to find out. When you try and build with Clang configured for x86 Debug, there are a ton of errors that look something like error: assembler label '' can not be undefined. I looked into this briefly and was able to narrow it down to the result.h header file, but didn't get much further than that.

@dunhor dunhor added bug Something isn't working help wanted Extra attention is needed clang Bugs or behavioral issues that are specific to Clang and removed bug Something isn't working labels May 9, 2019
@tiagomacarios
Copy link
Member

I reduced the minimal repro to be:

#include <intrin.h>
void f()
{
 __annotation(L"");
 __int2c();
}

clang-cl.exe -c -m32 -Zi a.cpp
error: assembler label '' can not be undefined
error: assembler label '' can not be undefined
2 errors generated.

This is a compiler bug, being tracked here: https://bugs.llvm.org/show_bug.cgi?id=41890

I am not familiar with __annotation, so it might be that there is a library workaround in the meantime.

@dunhor
Copy link
Member Author

dunhor commented May 15, 2019

Thanks for looking into this! That pretty much narrowed it down to WI_ASSERT*. I'll have a change out soon that will remove this annotation when building with Clang+Debug for 32-bit

@tiagomacarios
Copy link
Member

Fix landed on r360818 which might have a dependency on r360813
https://reviews.llvm.org/rG48824903499023be85e80eb3c53e77eab6f07a16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clang Bugs or behavioral issues that are specific to Clang help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants