Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting release to include win32metaddata #2811

Closed
LeonarddeR opened this issue Jan 19, 2024 · 9 comments · Fixed by #2812
Closed

Requesting release to include win32metaddata #2811

LeonarddeR opened this issue Jan 19, 2024 · 9 comments · Fixed by #2812
Labels
enhancement New feature or request

Comments

@LeonarddeR
Copy link

Suggestion

Version 57.0.42 of win32metadata contains interfaces for SAPI that were missing in the past. I'd like to create a new Rust project based on these interfaces.

@LeonarddeR LeonarddeR added the enhancement New feature or request label Jan 19, 2024
@ChrisDenton
Copy link
Collaborator

If microsoft/win32metadata#1788 is going to find its way into metadata soon then I'd quite like that to be included too. But also I don't want to block a release on that.

@kennykerr
Copy link
Collaborator

I'm bringing in the latest metadata here #2812. Chris, are the changes you're looking for included?

@ChrisDenton
Copy link
Collaborator

Oh, I didn't realise that's now closed. I'll take a look...

@ChrisDenton
Copy link
Collaborator

Yep! That seems to address my issue. Never mind then 🙂

@kennykerr
Copy link
Collaborator

Sweet! Note that I'm not planning a crates release - #2812 is just for updating the metadata and resulting code gen. Let me know if and when a particular crate release is needed for a production dependency.

@mikebattista
Copy link

@ChrisDenton I just fixed microsoft/win32metadata#1788 so it's not included in the latest published release.

@ChrisDenton
Copy link
Collaborator

Oh, hmm... yes you're right. It's in the generated metadata if you generate it manually. But not in the rust docs for #2812. Sorry for getting confused there.

@kennykerr
Copy link
Collaborator

Happy to suck in another update. Maybe check with @riverar and @ChrisDenton that we have everything we need for the next release.

@mikebattista
Copy link

I just pushed another update with microsoft/win32metadata#1788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants