Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Version is not sorted correctly for versions of type vXX.X #1298

Closed
Timber1900 opened this issue Jul 18, 2021 · 5 comments
Closed

Package Version is not sorted correctly for versions of type vXX.X #1298

Timber1900 opened this issue Jul 18, 2021 · 5 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@Timber1900
Copy link

Brief description of your issue

Packages whose version are written like vXX.x (eg. v10.1) aren't sorted correctly
image
image

Steps to reproduce

Look at the Timber1900.WebDL package, the latest version is v10.2, however the version that shows up in winget is the earliest v9.2

Expected behavior

Winget displaying the latest version as v10.2

Actual behavior

Winget displays the latest version as v9.2

Environment

Windows Package Manager v1.0.11591
Windows: Windows.Desktop v10.0.22000.71
Package: Microsoft.DesktopAppInstaller v1.11.11591.0
@ghost ghost added the Needs-Triage Issue need to be triaged label Jul 18, 2021
@quangkieu
Copy link

quangkieu commented Jul 18, 2021

I think this is issue that manifest did not updated. As winget does not access github directly. You should open ticket in winget-pkgs

@Timber1900
Copy link
Author

What do you mean by manifest did not updated.
All manifests are in the master branch of winget-pkgs, and installing with the -v v10.2 option installs the correct version, which makes me believe the problem is with the cli itself

@Timber1900
Copy link
Author

  • Also running winget show Timber100.WebDL --versions show all the versions in the incorrect ordering

image
Interestingly the .X part is sorted correctly, the only wrong part being v9 vs v10

@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage Issue need to be triaged labels Jul 19, 2021
@denelon denelon added this to the v.Next - Windows Package Manager milestone Jul 19, 2021
@gkroonder
Copy link

gkroonder commented Jul 21, 2021

Interestingly the .X part is sorted correctly, the only wrong part being v9 vs v10

It is sorting as alpha not numerical; zz9something is "greater" than zz1something. Same for v9 vs v1 (~v10).

But I think this is clear to the devs.

Regards,
George

@denelon
Copy link
Contributor

denelon commented Jan 23, 2023

I believe the sorting for Timber1900.WebDL has been worked out. We've got an open PR looking at better behavior for software versions with preambles, but this Issue looks safe to close.

version sorting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

4 participants