Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Package Issue]: ASIO4ALL - incorrect/invalid installer URL #136486

Closed
2 tasks done
BinToss opened this issue Jan 26, 2024 · 0 comments · Fixed by #136575
Closed
2 tasks done

[Package Issue]: ASIO4ALL - incorrect/invalid installer URL #136486

BinToss opened this issue Jan 26, 2024 · 0 comments · Fixed by #136575
Labels
In-PR Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone
1.7 Packages

Comments

@BinToss
Copy link

BinToss commented Jan 26, 2024

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

The package's InstallerUrl is incorrect, causing clients to download an HTML file and treat it as an EXE.
The SHA256 will also need to be updated.

current:

correct:

Steps to reproduce

PowerShell

Get-UrlContent 'https://www.asio4all.org/downloads_11/ASIO4ALL_2_15_English.exe'
output 
<!DOCTYPE html><html lang="en-US"><head><meta charset="UTF-8"/>
<script>var _ez_ab_test = 'mod203'</script>
[truncated to first two lines]

Actual behavior

Winget attempts to download an EXE, but the URL redirects to a webpage.

Expected behavior

  • WinGet should be be downloading from a URL that resolves to an EXE file.
  • The download should fail if the response header's content-type is not application/x-msdos-program.

Environment

<details>

Windows Package Manager v1.6.3482
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.3007
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.21.3482.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Disabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Disabled
LocalArchiveMalwareScanOverride           Disabled
</details>

Screenshots and Logs

No response
@BinToss BinToss added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jan 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 26, 2024
@Trenly Trenly mentioned this issue Jan 26, 2024
Merged
6 tasks
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 26, 2024
@denelon denelon added this to the 1.7 Packages milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In-PR Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
1.7 Packages
Development

Successfully merging a pull request may close this issue.

Update: MichaelTippach.ASIO4ALL version 2.15 Trenly/winget-pkgs
3 participants
@BinToss @denelon @stephengillie