Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Move versions from ExpressVPN.ExpressVPN to ExpressVPN.ExpressVPN.Preview #67863

Closed
mdanish-kh opened this issue Jul 29, 2022 · 3 comments
Milestone

Comments

@mdanish-kh
Copy link
Contributor

mdanish-kh commented Jul 29, 2022

Description of the new feature/enhancement

ExpressVPN has two versions of its package on their website https://www.expressvpn.com/latest#windows , an Early Preview version (uses ExpressVPN lightway protocol), and normal release (not optimized for ExpressVPN lightway protocol). Both can be useful versions to the users so it may be a good idea to include both.

Currently both types of versions are included in the ExpressVPN.ExpressVPN directory, ExpressVPN version 10's are all standard releases and version 12's are all early preview releases.

The question is, should we move version 12's to new directory ExpressVPN.ExpressVPN.Preview? Or just get rid of preview releases? Or let them stay in the current directory? As winget currently does not have support for release channels, what could be the implications in upgrade scenario as a consequence of this move?

Some Considerations

  • Both cannot be installed side-by-side (they install to same directory)
  • Both have same DisplayName
  • Both make two ARP entries to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall (one is unique so maybe that can be used as primary ARP entry??)
    image
    image

Proposed technical implementation details (optional)

No response

If moderators approve of this move, then I can start making the manifests.

@mdanish-kh mdanish-kh added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 29, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jul 29, 2022
@denelon denelon added Help-Wanted This is a good candidate work item from the community. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage This work item needs to be triaged by a member of the core team. labels Jul 29, 2022
@russellbanks
Copy link
Contributor

+1 for splitting the packages into ExpressVPN.ExpressVPN and ExpressVPN.ExpressVPN.Preview. I would suggest only keeping the latest version in ExpressVPN.ExpressVPN.Preview because those versions will probably end up in the stable release channel eventually anyway.

@Trenly
Copy link
Contributor

Trenly commented Jan 26, 2024

@mdanish-kh - Do these still need to be split out?

@mdanish-kh
Copy link
Contributor Author

I just checked again, and I believe Version 12s are all stable releases now, so there's no need now for moving these packages

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Help-Wanted This is a good candidate work item from the community. label Jan 26, 2024
@denelon denelon added this to the 1.7 Packages milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants