Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Class name in comment would not compile #256

Closed
codecadwallader opened this issue Jun 5, 2018 — with docs.microsoft.com · 4 comments
Closed

Class name in comment would not compile #256

codecadwallader opened this issue Jun 5, 2018 — with docs.microsoft.com · 4 comments

Comments

Copy link

There's a commented out example above:

// Alternatively you can request data for a subset of campaigns or ad groups.
//Scope = new AccountThroughAdGroupReportScope
//{
// AccountIds = null,
// Campaigns = new[] {
// new AdGroupReportScope
// {
// AccountId = accountId,
// CampaignId = <YourCampaignIdGoesHere>,
// AdGroupId = <YourAdGroupIdGoesHere>
// }
// }
//},

However an AdGroupReportScope cannot be assigned to Campaigns.. this should be CampaignReportScope.

Thanks!


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Copy link
Author

or on further thought.. perhaps its intended to be assigned to AdGroupReports (instead of Campaigns). In that case the class name is right, its what the array is being assigned to that needs updated.

Copy link
Author

In other words..
// AdGroups = new[] {
// new AdGroupReportScope

@eric-urban
Copy link
Collaborator

@codecadwallader good catch thanks! Looks like a copy/paste error with the commented out code (compile didn't catch it). We've updated the sample in the SDK repository, and will update Docs next opportunity.

@codecadwallader
Copy link
Author

Looks good, thanks for the quick turnaround!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants