Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Container Instance group docs; does "create" with same properties restart the containers? #120542

Closed
timotk opened this issue Mar 7, 2024 · 5 comments

Comments

@timotk
Copy link
Contributor

timotk commented Mar 7, 2024

Details

Service: Azure Container Instances
Relevant documentation: https://learn.microsoft.com/en-us/azure/container-instances/container-instances-update
Feedback:

The docs do not explicitly state whether the containers are updated, when the properties of the az container create command stay the same.

It does say:

Modify or add at least one property of the group that supports update when you redeploy.

But this does not state explicitly what happens when no properties are modified.

It is very useful to know this, because you might use it during the following deployment process:

  1. Create (or update) container instances
  2. Restart container (optional or not?)

Preferred situation:

State explicitly what happens when NO properties are being updated. Does the container get restarted? Or not? Do we manually need to restart the container?


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@SaibabaBalapur-MSFT
Copy link
Contributor

@timotk
Thanks for your feedback! We will investigate and update as appropriate.

@Naveenommi-MSFT
Copy link
Contributor

@timotk
Thank you for bringing this to our attention.
I've delegated this to content author @tomvcassidy, who will review it and offer their insightful opinions.

@Naveenommi-MSFT
Copy link
Contributor

@tomvcassidy
Could you please review add comments on this, update as appropriate.

@tomvcassidy
Copy link
Contributor

Hi @timotk ! Sorry for the delay. I checked with the product team and running a create command a second time with all the same properties and values you included the first time and with no properties added or values modified will result in a container restart. You could also use az container restart to achieve this.

I've added a note to the document to clarify this point for future readers. It is merged as of https://github.com/MicrosoftDocs/azure-docs-pr/pull/273393 and will be published later today.

Thanks, and if you find anything else that needs clarification in the documentation, please let us know.

#please-close

@timotk
Copy link
Contributor Author

timotk commented Apr 26, 2024

Hi @tomvcassidy , thanks for updating! However, the PR link doesn't work, so I can't see the exact changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants