Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Sageo UI Images to white Font when Black Theme is enabled #10

Closed
christian-becker-ta opened this issue Feb 17, 2017 · 5 comments
Closed

Change Sageo UI Images to white Font when Black Theme is enabled #10

christian-becker-ta opened this issue Feb 17, 2017 · 5 comments

Comments

@christian-becker-ta
Copy link

Change Sageo UI Images to white Font when Black Theme is enabled.

Can't see the icons on black theme,
@mattwojo
Copy link
Contributor

mattwojo commented Feb 22, 2017 •
edited
Loading

Hi @timejump - Thanks for filing this issue. Are these the icons you are referring to in the black theme...?
image

I agree that these are harder to see in blue. I'll connect with the platform devs and see if there is a reason for not changing these to the white (or light grey) font.

@christian-becker-ta
Copy link
Author

Hi @mattwojo
no i mean the icons a few sites down.
image

@mattwojo
Copy link
Contributor

mattwojo commented Mar 7, 2017

Ahh -- I see what your talking about now. Agh, not good. Let me see what I can do. Thanks @timejump!

@christian-becker-ta
Copy link
Author

Thanks @mattwojo
This is clever :)
image

@mattwojo
Copy link
Contributor

Thanks @timejump -- Please let us know if you see any other issues. Closing this one out. 👍

mijacobs pushed a commit that referenced this issue Mar 15, 2019
@LucasHaines @mijacobs
updating image (#10)
8c17acb 
* updating explict font sizes from 15 to 14 in response to the Density work

* updating image

* Updating image: forgot to update the image for normal body text size
@mattwojo mattwojo mentioned this issue Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christian-becker-ta @mattwojo