-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: permissions tab UI #815
Conversation
@ElinorW it will be a better user experience to be able to open the permissions panel from the modify permissions tab instead of showing them instructions on how to open the permissions panel. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-815.centralus.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-815.centralus.azurestaticapps.net |
* Fix - replaces content-type header by accept to match HTTP and avoid CORS pre-flight (#783) * Fix: modify permissions tab UI (#790) * Track errors (#777) * Fix: sanitize url when fetching permissions (#794) * Fix: remove wrongly placed working (#795) * Fix: all permissions show as required (#797) * Task: autocomplete hover styling (#801) * Fix: Enable screen reader confirmation feedback (#802) * Migrate to eslint (#627) * Feature: resizable components (#766) * Fix: add onItemInvoked action (#806) * Fix: permissions consent (#807) * Task: accessibility ci (#358) * Fix: prevent resize when view expanded (#816) * Feature: additional telemetry (#813) * Fix: permissions tab UI (#815) * Fix: shrink request section (#822) Co-authored-by: jobala <japhethobalak@gmail.com> Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com> Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com> Co-authored-by: Azure Static Web Apps <opensource@microsoft.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com> Co-authored-by: Vincent Biret <vibiret@microsoft.com> Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
Overview
Fixes #739
fixes #560
Demo
Permissions tab with tooltip
![image](https://user-images.githubusercontent.com/18407044/105989805-ad210680-60b2-11eb-83f3-c73979a71a1a.png)
Permissions tab when there are no permissions (User signed in)
![image](https://user-images.githubusercontent.com/18407044/106291194-63741f80-625c-11eb-800d-f7ad6f366ad7.png)
Permissions tab when there are no permissions (User not signed in)
![image](https://user-images.githubusercontent.com/18407044/106291459-b1892300-625c-11eb-9bfb-d2b187c67b22.png)