fix: flyout vertical positioning #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjusts logic for setting height on the flyout to only apply a set height on the second pass if necessary. this ensures that any content in the flyout is given a chance to render and contribute to the flyout height before an fixed height is applied to the flyout.
|
📖 The updated storybook is available here |
1 similar comment
|
📖 The updated storybook is available here |
|
@vagpt I believe that the linked a11y issue raised has been resolved by this PR as now the flyout will not position itself outside of the bounds of the visible portion of the page. |
sebastienlevert
approved these changes
Oct 12, 2023
|
Hi @gavinbarron, Could you please provide us updated URL again as provided PR link above is not opening and we are getting 404 error. |
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2258
Closes #2757
PR Type
Description of the changes
adjusts logic for setting height on the flyout to only apply a set height on the second pass if necessary. this ensures that any content in the flyout is given a chance to render and contribute to the flyout height before an fixed height is applied to the flyout.
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information