Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename mgt-tasks to mgt-planner #2890

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Nov 30, 2023

Closes #2889 #2321

PR Type

  • Feature

Description of the changes

renames component to better suit current usage
removes dead code calling deprecated Graph APIs for Outlook Tasks moves a number of strings into the localizable string collection for the component updates the generate script for mgt-react to clean files at the start of generation

BREAKING CHANGE: mgt-tasks has been removed and replaced with mgt-planner. mgt-planner does not support data-source switching to fetch data from the outlook tasks apis any longer.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation PR: Link to docs PR
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

renames component to better suit current usage
removes dead code calling deprecated Graph APIs for Outlook Tasks
moves a number of strings into the localizable string collection for the component
updates the generate script for mgt-react to clean files at the start of generation

BREAKING CHANGE: mgt-tasks has been removed and replaced with mgt-planner. mgt-planner does not support data-source switching to fetch data from the outlook tasks apis any longer.
Copy link

📖 The updated storybook is available here

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon to view more actions for a task is not loading correctly.
image

@Mnickii
Copy link
Collaborator

Mnickii commented Nov 30, 2023

The icon to view more actions for a task is not loading correctly. image

I found using an SVG icon in mgt-dot-options fixes this

@sebastienlevert
Copy link
Contributor

An interesting behavior (I don't know if it's related to the component rename).

When moving from "Assigned to me" to a specific plan, if the plan has no tasks, the UI doesn't update and "sticks" with the previous set of tasks.

For instance:

image

And then when I click on Server MTL-001 is broken, I get the same set of tasks, but just in another view? So it looks like it's not updating the tasks based on the user's selection.

image

@gavinbarron gavinbarron linked an issue Nov 30, 2023 that may be closed by this pull request
@gavinbarron
Copy link
Member Author

Oh that's an interesting find @sebastienlevert

Does mgt-tasks behave that way on https://mgt.dev/next ? If so, then let's address it as a separate work item.

@gavinbarron
Copy link
Member Author

Actually, it looks like the filtering is profoundly broken in main at the moment.

@gavinbarron
Copy link
Member Author

Filtering issue is tracked by #2893

Copy link

github-actions bot commented Dec 1, 2023

📖 The updated storybook is available here

sebastienlevert
sebastienlevert previously approved these changes Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

📖 The updated storybook is available here

Copy link

github-actions bot commented Dec 1, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 80% 100% 0
mgt-components.src.components.mgt-contact 63% 100% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-get 30% 100% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 81% 65% 0
mgt-components.src.components.mgt-person-card 64% 50% 0
mgt-components.src.components.mgt-picker 78% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 77% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-arrow-options 71% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 19% 0
mgt-element.dist.es6.components.src.components 73% 80% 0
mgt-element.dist.es6.mock.src.mock 90% 72% 0
mgt-element.dist.es6.providers.src.providers 85% 69% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 84% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 66% (14020 / 21364) 64% (412 / 646) 0

Copy link

github-actions bot commented Dec 1, 2023

📖 The updated storybook is available here

@gavinbarron
Copy link
Member Author

The image for the dot options has been fixed in the todo change from @Mnickii
a task in mgt-planner with the dot options menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[mgt-tasks] Deprecate and move to mgt-planner Localize strings used in mgt-task components
4 participants