Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set add button to disabled until task name is provided #2996

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Jan 30, 2024

Closes #2302

PR Type

  • Bugfix

Description of the changes

  • Set the add button to disabled until the task name is provided.
  • fix planner localization string

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the v4.1.0 milestone Jan 30, 2024
@musale musale requested a review from a team as a code owner January 30, 2024 14:37
Copy link

📖 The updated storybook is available here

1 similar comment
Copy link

📖 The updated storybook is available here

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also, thank you for fixing that localization story

Copy link

github-actions bot commented Feb 1, 2024

📖 The updated storybook is available here

@musale
Copy link
Contributor Author

musale commented Feb 2, 2024

@vagpt ready for a11y review

Copy link

github-actions bot commented Feb 2, 2024

📖 The updated storybook is available here

@gavinbarron gavinbarron modified the milestones: v4.1.0, v4.0.0 Feb 2, 2024
@gavinbarron gavinbarron enabled auto-merge (squash) February 2, 2024 20:05
@gavinbarron gavinbarron merged commit eec74d0 into main Feb 2, 2024
9 checks passed
@gavinbarron gavinbarron deleted the fix/add-btn-disabled-nofocus branch February 2, 2024 20:09
Copy link

github-actions bot commented Feb 2, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 85% 67% 0
mgt-components.src.components.mgt-contact 63% 100% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 72% 0
mgt-components.src.components.mgt-person-card 56% 54% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 78% 12% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 90% 72% 0
mgt-element.dist.es6.providers.src.providers 85% 73% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 67% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 65% (13960 / 21449) 65% (420 / 643) 0

Copy link

github-actions bot commented Feb 2, 2024

📖 The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants