Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a part of installation install transform-class-properties on the host app. #77

Open
sivakumar-kailasam opened this issue Nov 28, 2018 · 1 comment
Labels

Comments

@sivakumar-kailasam
Copy link
Member

sivakumar-kailasam commented Nov 28, 2018

This would be required in case the host app wants to define models in js files with class properties.

In addition to this, if they're using eslint, we'll have to add babel-eslint as a devDep & add the line `parser: 'babel-eslint' to their eslint config file.

Or we could add these to be a part of setup instructions & show how they can define props w/o class properties if they wish to do so.

@taras
Copy link
Member

taras commented Nov 28, 2018

This would be required in case the host app wants to define models in js files with class properties.

This is not strictly required, but it's more verbose without it for sure. They can always do

class Person {
  constructor() {
    this.firstName = String;
    this.lastName = String;
  }
}

But I agree, transform would be better. Should it be installed via a blueprint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants