Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micu/fix menu sitution 82 #83

Merged
merged 11 commits into from May 6, 2017
Merged

Micu/fix menu sitution 82 #83

merged 11 commits into from May 6, 2017

Commits on Apr 20, 2017

  1. [v-play] Extract NavigationStackWithPushAttached

    We extract the functionality we added to v-play
    for being able to just attach a page to the navigation
    stack into its own component.
    
    // Github issue #82
    micuintus committed Apr 20, 2017
    Copy the full SHA
    041d67e View commit details
    Browse the repository at this point in the history
  2. Fix #82: Straighten out menu situation

    With the food and shopping menu entries in place,
    on SailfishOS the menu behaves weirdly: The shopping list
    gets pushed as a new page onto the stack of the food list
    (without a 'PullDownMenu', which is still on the food list page).
    
    We therefore create the entity of an 'ActionMenuItem',
    which closely resembles Sailfish's PullDownMenu's 'MenuItem':
    It has a 'clicked' signal, which you can connect to
    for triggering some action when the menu item was clicked.
    
    Currently, the 'ActionMenu' item uses the page component that
    has been assigned to the 'initialPage' property of the
    'ApplicationWindow'.
    
    The 'NavigationMenu' abstraction on Sailfish is adapted in a
    way that the menu automatically assigns itself to the first
    page of Sailfish's global 'pageStack' (if it has a valid
    'flickable' the 'PullDownMenu' can be attached to).
    micuintus committed Apr 20, 2017
    Copy the full SHA
    dd3dd7b View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2017

  1. Make VenueList::jsonModelCollection an alias

    (avoids unnecessary indirection).
    micuintus committed Apr 23, 2017
    Copy the full SHA
    8b05b2d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2017

  1. Simplify components-Sailfish/NavigationMenu.qml

    // Github issue #82
    micuintus committed Apr 29, 2017
    Copy the full SHA
    48d0269 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2017

  1. Don't use State based approach

    as nice as it is --- but unfortunately it is
    overkill for our use case.
    
    // Github issue #82
    micuintus committed May 1, 2017
    Copy the full SHA
    9bb78e2 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2017

  1. Remove superfluous log output

    (vestige from debugging).
    micuintus committed May 3, 2017
    Copy the full SHA
    8aea76b View commit details
    Browse the repository at this point in the history

Commits on May 4, 2017

  1. Fix bug of virtual keyboard loosing the focus

    With Github issue #82 the bug of the virtual keyboard
    loosing the focus was temporarily re-introduced.
    
    // Github issue #82
    micuintus committed May 4, 2017
    Copy the full SHA
    0a34053 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2017

  1. [v-play] Introduce a SearchField abstraction

    for both V-Play and Sailfish: This allows us
    to put the search bar in the header of the flickable
    on SailfishOS, but have it as a static item on top
    of the venue list on V-Play.
    
    Closes #84
    micuintus committed May 5, 2017
    Copy the full SHA
    7d6f9c6 View commit details
    Browse the repository at this point in the history
  2. Sync search bar of venue list and shopping list

    // Github issue #82
    micuintus committed May 5, 2017
    Copy the full SHA
    a84a779 View commit details
    Browse the repository at this point in the history
  3. Give pageToVisit a less ridiculous name

    // Github issue #82
    micuintus committed May 5, 2017
    Copy the full SHA
    83f0292 View commit details
    Browse the repository at this point in the history
  4. Explicify page component to use in ActionMenuItem

    and don't implicitly use app.initialPage
    
    // Github issue #82
    micuintus committed May 5, 2017
    Copy the full SHA
    7cc7868 View commit details
    Browse the repository at this point in the history