Micu/fix menu sitution 82 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We extract the functionality we added to v-play for being able to just attach a page to the navigation stack into its own component. // Github issue #82
With the food and shopping menu entries in place, on SailfishOS the menu behaves weirdly: The shopping list gets pushed as a new page onto the stack of the food list (without a 'PullDownMenu', which is still on the food list page). We therefore create the entity of an 'ActionMenuItem', which closely resembles Sailfish's PullDownMenu's 'MenuItem': It has a 'clicked' signal, which you can connect to for triggering some action when the menu item was clicked. Currently, the 'ActionMenu' item uses the page component that has been assigned to the 'initialPage' property of the 'ApplicationWindow'. The 'NavigationMenu' abstraction on Sailfish is adapted in a way that the menu automatically assigns itself to the first page of Sailfish's global 'pageStack' (if it has a valid 'flickable' the 'PullDownMenu' can be attached to).
|
This is just awesome! Thank you very much. I noticed one little thing: If I put in a search term in let's say the venue list like "food" and switch over to the shopping list, the search term stays, but the list is not refreshed. Could you refresh the list or clear the search field on switch? |
|
After some further investigations I noticed, that (on a v-play build) I loose the virtual keyboard after typing in "F" in the venue list and "Fo" in the shopping list. Without your patch, that does not happen. Can you reproduce that? |
(avoids unnecessary indirection).
// Github issue #82
as nice as it is --- but unfortunately it is overkill for our use case. // Github issue #82
(vestige from debugging).
for both V-Play and Sailfish: This allows us to put the search bar in the header of the flickable on SailfishOS, but have it as a static item on top of the venue list on V-Play. Closes #84
// Github issue #82
// Github issue #82
and don't implicitly use app.initialPage // Github issue #82
jmastr
approved these changes
May 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.