Limit handling of files to specified outputs types & usable templating langs #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very smart 👍 |
stevenosloan
force-pushed
the
filter_out_unhandled_types
branch
from
8eab0c7
to
cb42719
Compare
stevenosloan
changed the title
…g langs Adds a check for `processable?` that checks against: - output types that we select (for now .css & .js) - input types that sprockets can handle This should alleviate issues where html files, dot files, or template types that sprockets doesn’t support (less for example) throw errors while middleman itself can handle them just fine. We might start to see reports of sprockets *not* handling files as user would expect (.less for example), so it’s something to be aware of. [close middleman#90, middleman#85]
stevenosloan
force-pushed
the
filter_out_unhandled_types
branch
from
cb42719
to
cbe957c
Compare
This was referenced Feb 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check for
processable?that checks against:This should alleviate issues where html files, dot files, or template types that sprockets doesn’t support (less for example) throw errors while middleman itself can handle them just fine. We might start to see reports of sprockets not handling files as user would expect (.less for example), so it’s something to be aware of.
This should close #90, #85, and cover the html case of #87.
@eaigner, @morgoth, @Aetherus if y'all can give this a shot that'd be great. To test, in your Gemfile: