Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] warmup can be replaced by Provisioned Concurrency #435

Closed
willfarrell opened this issue Dec 6, 2019 · 3 comments
Closed

[Docs] warmup can be replaced by Provisioned Concurrency #435

willfarrell opened this issue Dec 6, 2019 · 3 comments

Comments

@willfarrell
Copy link
Member

There is a new feature with Lambda that allows for a lambda to stay warm, deprecating the need for a warmup trigger.

For v1-beta and onwards I think we should deprecate. Thoughts?

@willfarrell willfarrell changed the title Middleware: warmup can be replaced by Provisioned Concurrency warmup can be replaced by Provisioned Concurrency Dec 6, 2019
@lmammino
Copy link
Member

lmammino commented Dec 6, 2019

That's a very good point and I agree. Before deprecating we should update the readme with some sort of migration guide

@willfarrell
Copy link
Member Author

willfarrell commented Dec 6, 2019

I've been playing around with it using serverless, it's not as simple as their blog post makes it look and no additional docs on their side.

To be able to do it "correct";

  • Deploy your function w/ a version tag (not done by default)
  • Apply an alias to that new version (serverless-aws-alias)
  • Attach provisionedConcurrency to that alias

Each of these steps is poorly documented. So, I would say keep an eye out for blog posts on this.

I did try in terraform as well, brain dead easy to apply. https://github.com/willfarrell/terraform-ec-modules/blob/master/lambda/lambda.tf#L103

@willfarrell willfarrell changed the title warmup can be replaced by Provisioned Concurrency [Docs] warmup can be replaced by Provisioned Concurrency Dec 6, 2019
@lmammino
Copy link
Member

lmammino commented Dec 6, 2019

Yeah, i guess it's still a bit too early to have a decent body of documentation.
In any case i am very supportive of this. if we can put together few lines (and maybe some doc links) that would be more than enough to provide guidance for the migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants