Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move @types/aws-lambda to devDependencies #566

Closed
baileytincher opened this issue Oct 13, 2020 · 2 comments
Closed

Move @types/aws-lambda to devDependencies #566

baileytincher opened this issue Oct 13, 2020 · 2 comments

Comments

@baileytincher
Copy link
Contributor

middy/packages/core/package.json

Line 39 in e17f9a4

"@types/aws-lambda": "^8.10.3"

Semantics issue, but since typedefs get compiled out when you build with Babel it makes more sense to leave them in devDependencies. At the moment serverless throws warnings even though it isn't a true dependency.
@willfarrell
Copy link
Member

I'm open to a PR for this.

@willfarrell
Copy link
Member

Will be in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willfarrell @baileytincher