Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Middlewares #99

Closed
i-am-kenny opened this issue Jan 23, 2018 · 4 comments
Closed

Various Middlewares #99

i-am-kenny opened this issue Jan 23, 2018 · 4 comments

Comments

@i-am-kenny
Copy link
Contributor

Hey folks! I came across Middy a few days ago, and I've been slowly reorganizing one of my applications to take advantage of it. I've also generated a small library of middleware that someone else may be interested in. Take a look and feel free to give me some feedback.

https://github.com/i-am-kenny/remiddy
@lmammino
Copy link
Member

Very very impressive job :) lots of useful middlewares in there!
It would be nice to have some of them as default middlewares directly embedded in middy. For example, your withDefaultHttpEvent would close a long time outstanding issue (#35).

Feel free to submit a PR for it!

@kevinrambaud
Copy link
Contributor

hey @lmammino what about decentralizing middlewares and try to keep middy core as small as possible ? It would facilitate contribution.

@vladholubiev
Copy link
Contributor

See discussion in #78 (comment) and below, this is where it moves

@kevinrambaud
Copy link
Contributor

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lmammino @willfarrell @i-am-kenny @vladholubiev @kevinrambaud