Skip to content
This repository has been archived by the owner on Jul 2, 2020. It is now read-only.

fix: copyFiles to protected #86

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Conversation

echosoar
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #86 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #86      +/-   ##
=========================================
- Coverage   76.73%   76.7%   -0.04%     
=========================================
  Files          71      71              
  Lines        2484    2485       +1     
  Branches      233     236       +3     
=========================================
  Hits         1906    1906              
- Misses        576     577       +1     
  Partials        2       2
Impacted Files Coverage Δ
packages/serverless-invoke/src/core.ts 77% <100%> (ø) ⬆️
packages/faas-cli-command-core/src/core.ts 63.52% <42.85%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ea5b3...5a1ad82. Read the comment docs.

@echosoar
Copy link
Member Author

echosoar commented Mar 16, 2020

  • command-core性能优化
    From:
    Benchmark:
      core help no plugin  x 202,982 ops/sec ±0.88% (89 runs sampled)
      core help test plugin x 114,183 ops/sec ±1.03% (86 runs sampled)
      core invoke test plugin x 104,416 ops/sec ±1.26% (71 runs sampled)
    
    To:
    Benchmark:
      core help no plugin  x 304,842 ops/sec ±4.32% (72 runs sampled)
      core help test plugin x 144,904 ops/sec ±4.23% (77 runs sampled)
      core invoke test plugin x 134,072 ops/sec ±3.13% (75 runs sampled)
    
  • command-core 单测覆盖率提升
  • 移除 command-core deepMerge 依赖
  • serverless-invoke copyFiles 设置为 protected,供子类继承调用

@czy88840616 czy88840616 merged commit bf54687 into master Mar 16, 2020
@czy88840616 czy88840616 deleted the fix/protected-and-benchmark branch March 16, 2020 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants