Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add app.keys #1395

Merged
merged 5 commits into from
Dec 3, 2021
Merged

fix: add app.keys #1395

merged 5 commits into from
Dec 3, 2021

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Dec 3, 2021

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #1395 (10e3754) into 3.x (77af5c0) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.x    #1395      +/-   ##
==========================================
- Coverage   81.68%   81.65%   -0.04%     
==========================================
  Files         301      301              
  Lines       10271    10281      +10     
  Branches     2244     2184      -60     
==========================================
+ Hits         8390     8395       +5     
- Misses       1715     1768      +53     
+ Partials      166      118      -48     
Impacted Files Coverage Δ
packages/web-koa/src/configuration.ts 100.00% <ø> (ø)
packages/core/src/error/framework.ts 68.96% <33.33%> (-4.12%) ⬇️
packages/web-koa/src/framework.ts 65.00% <50.00%> (-1.22%) ⬇️
packages/core/src/error/code.ts 100.00% <100.00%> (ø)
packages/core/src/setup.ts 89.23% <0.00%> (ø)
packages/rabbitmq/src/mq.ts 74.13% <0.00%> (ø)
packages/logger/src/rotate.ts 81.05% <0.00%> (ø)
packages/logger/src/container.ts 53.06% <0.00%> (ø)
packages/web/src/framework/web.ts 87.50% <0.00%> (ø)
packages/mock/src/client/rabbitMQ.ts 5.96% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77af5c0...10e3754. Read the comment docs.

@czy88840616 czy88840616 merged commit c44afc6 into 3.x Dec 3, 2021
@czy88840616 czy88840616 deleted the fix_app_keys branch December 3, 2021 08:51
@czy88840616 czy88840616 mentioned this pull request Dec 8, 2021
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants