Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change captionText to use innerHTML instead of textContent #88

Closed
mbabini opened this issue Nov 17, 2021 · 4 comments
Closed

Change captionText to use innerHTML instead of textContent #88

mbabini opened this issue Nov 17, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@mbabini
Copy link

mbabini commented Nov 17, 2021

Hi

It would be great if the output of the captionText function could contain HTML code like line breaks or links.

I suggest the following change:
original:
this.userSettings.captionText?r.textContent=this.userSettings.captionText(e)

new:
this.userSettings.captionText?r.innerHTML=this.userSettings.captionText(e)

Thank you!
@viliusle
Copy link
Collaborator

This can be done easily, of course needs some testing.

@midzer
Copy link
Owner

midzer commented Dec 10, 2021

We could try it in develop branch.

@mbabini Do you mind opening a PR for this?

@midzer midzer added the enhancement New feature or request label Dec 10, 2021
@mbabini
Copy link
Author

mbabini commented Dec 10, 2021

@midzer I've tried: #92
But please check because it's my very first PR... ;-)

@midzer
Copy link
Owner

midzer commented Dec 26, 2022

Should by done by b43119e

@midzer midzer closed this as completed Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@viliusle @midzer @mbabini