Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request timeout middleware dns.HandlerFunc #1539

Closed
jimlambrt opened this issue Feb 23, 2024 · 1 comment
Closed

Request timeout middleware dns.HandlerFunc #1539

jimlambrt opened this issue Feb 23, 2024 · 1 comment

Comments

@jimlambrt
Copy link
Contributor

Is there any desire to include a sort of middleware dns.HandlerFunc which provides support for request timeouts via a request context?

It's a pretty straightforward thing to make and I've pulled something together which I'm happy to contribute via a PR (and get rid of my pkg). Let me know if there's any interest and I'll open a PR.

Here's what I'm proposing to contribute: github.com/jimlambrt/respwriter

@miekg
Copy link
Owner

miekg commented Mar 29, 2024

coredns implements a whole bunch of middlewares, I don't think it makes sense to pull more into this package. I mean if we pull this in, where do we stop?

@miekg miekg closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants