Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Item BG Color Hovered #234

Closed
zeoint opened this issue Aug 10, 2023 · 7 comments
Closed

List Item BG Color Hovered #234

zeoint opened this issue Aug 10, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@zeoint
Copy link

zeoint commented Aug 10, 2023

Type of installation

Portable (.zip)

Steps to reproduce

List Item BG Color Hovered is not working for drop down list items, instead they are linked to button foucs color.

  1. Open theme maker.
  2. Cycle through any drop down list.
  3. You can see the hover color.
  4. Change ListI tem BG Color Hovered to another color and repeat step 2.
  5. You cannot see the chosen color.
  6. Change button focus color to another color and repeat step 2.
  7. You can see the chosen color on hovering over the items in the drop down list.

✔️ Expected Behavior

Since it is a hover action on drop down list item, it should be linked to List Item BG Color Hovered instead of button focus color.

❌ Actual Behavior

List item BG Color Hovered is not linked to,

  • drop down menu items on hover (Instead button focus color is linked to this.)
@zeoint zeoint added the bug Something isn't working label Aug 10, 2023
@zeoint
Copy link
Author

zeoint commented Aug 10, 2023

This is just a minor thing, but there is no gap on some words in theme maker. Two words are combined as one.

  • ListItem ->List Item
  • ScrollBar -> Scroll Bar
  • ContextMenu -> Context Menu

@mienaiyami
Copy link
Owner

It is as intended, everything from BG color to focused color is linked to button.
Let me know if there is an issue with that. If not, I will be closing it as not planned.

@zeoint
Copy link
Author

zeoint commented Aug 17, 2023

It is as intended, everything from BG color to focused color is linked to button.
✔️ Expected Behavior
Since it is a hover action on drop down list item, it should be linked to List Item BG Color Hovered instead of button focus color.

But the 'list item bg color hovered' is still linked to 'button focus color'.


@zeoint
Copy link
Author

zeoint commented Aug 17, 2023

I like to link the button focus color to button color.
When I hover the list items (be it in themes list or reader settings list), the hover color is not seen because that is linked to button focus color instead of list item bg color hovered.
But they are list items so shouldn't they be linked to list item bg color hovered?

@mienaiyami
Copy link
Owner

Since it is a hover action on drop down list item, it should be linked to List Item BG Color Hovered instead of button focus color.

You see, select options are focused on mouse over, it's not actually hover, kind of. If you click enter of space while mouse is over an option you will notice that, also when you use arrow keys to move selection.

I will be changing BG color of select option to "context menu". If it fits better.

@zeoint
Copy link
Author

zeoint commented Aug 17, 2023

Cool.

@mienaiyami
Copy link
Owner

Hover/focused color is now linked to context menu item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants