Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.6.3.20]Functionality of scanning common or rare ores becomes invalid #48

Closed
nizhuan-jjr opened this issue Aug 22, 2018 · 2 comments
Closed

Comments

@nizhuan-jjr
Copy link

Whether the ores is vanilla or custom, the scanner won't show the location for them now.

Prepared to scan
2018-08-22_11 30 23

Right after the scan
2018-08-22_11 30 34

Actual location of the ores(left:oreGold; up:oreCoal; bottom:oreRuby(from Pixelmon Reforged 6.3.4); right: pixelmon:fire_stone_ore(from Pixelmon Reforged 6.3.4))
2018-08-22_11 31 45

This is the scannable configuration file which I added the support to Pixelmon Reforged 6.3.4.
scannable.cfg.txt

@nizhuan-jjr
Copy link
Author

The animal module and the monster module work fine.

fnuecke added a commit that referenced this issue Aug 22, 2018
…ck results as game overlay instead of in world render pass now when shaders are used (needs extra copying of depth into separate texture so only doing that when actually using shaders to save ourselves that work otherwise). Fixes #48.
@fnuecke
Copy link
Member

fnuecke commented Aug 22, 2018

Yeah, it still renders the results, they're just barely/not really visible due to OptiFine shaders and the scan effect/result rendering not being "compatible" so to say. Usually this just resulted in slightly off coloring/brightness, but it's much worse when the shaders use a gbuffer for example. I've just not had the time to work around this until now.

However! In the next build this should work with all kinds of shaders now, as I'm rendering the effect and results in the UI layer basically, which shaders shouldn't really touch anyway. This needs some extra work, so only doing that when shaders are actually in use, but yeah.

@fnuecke fnuecke closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants