-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octane / module unification support #883
Comments
Here is a test app: https://github.com/NullVoxPopuli/test-ember-paper-with-module-unification Some notes on setting things up:
blueprint still using classic layout -- which is fine. I move content to src/ui/styles/app.scss
So, I'm not sure if this is a module-unification issue or an ember-paper one. //cc @miguelcobain @mixonic |
good news: the only remaining TODO is to:
|
@NullVoxPopuli it would be nice we could detect if the addon is being installed in an MU enabled app and create the scss file accordingly. |
@miguelcobain I think there is an |
Yes, I also think we need an API for that. See how it has been detected at |
@NullVoxPopuli emberjs/ember.js#17234 (comment)
This particular issue is that the blueprint generator does not create file in the correct location for MU apps and it should be fixed by #1054
|
I did:
I moved app/styles/app.scss to ui/styles/app.scss
Got this error
So, I moved the file back to app/styles/app.scss, and the problem/error was the exact same.
I even tried the steps again without moving the defaultly generated file.
The text was updated successfully, but these errors were encountered: