Upgrade to Ember 2.13.3

[bjornharrtell]

No description provided.

[miguelcobain]

Is #705 fixed on this ember version?

[bjornharrtell]

Should be yes, this one: emberjs/ember.js#15247.

[bjornharrtell]

[bjornharrtell]

Getting ENOENT: no such file or directory, scandir '/home/travis/build/miguelcobain/ember-paper/node_modules/node-sass/vendor' failure at Travis.. which seem unrelated to this, not sure what is going on.

[bjornharrtell]

Still not sure what is going on at Travis but it appears I was too fast again to draw conclusions about #694 no longer being an issue. Seems like the yarn.lock is confusing me. After cearing out node_modules and installing with yarn install --no-lockfile the qunitjs related problem manifested itself again. So I have reverted that change and squashed this PR to only involve the Ember upgrade again.

[bjornharrtell]

I suspect another "compatible" silent semver upgrade (I'm really starting to unlike ^ and ~ for deps), in this case of node-sass. Will investigate.

[bjornharrtell]

Downgrading node-sass to 4.5.2 resolved the Travis CI issue. Should not be related to the Ember upgrade, and node-sass 4.5.3 which was released two days ago will likely cause build failures for any new commit. @miguelcobain let me know if you want me to move this fix to a separate PR.

[bjornharrtell]

I have created sass/node-sass#1971 for the upstream issue.

[bjornharrtell]

While testing the dummy application I discovered a runtime problem. When navigating away from the Grid List demo page I get the following exception:

calling set on destroyed object: <dummy@component:paper-grid-list::ember1849>.layoutInvalidated = false

After which stuff is broken.

[bjornharrtell]

Fixed by checking for isDestroyed and if true bailing the custom doLayout implementation. Running through the dummy demo pages seems fine now.

[miguelcobain]

That bug was already there.

[bjornharrtell]

Ok, should I remove, keep or extract the grid fix to another PR? And about node-sass upstream claims it's probably an issue with the Yarn cache but removing the use of Yarn cache from the travis yml doesn't help, so I'm not sure how to proceed with that either. :(

[bjornharrtell]

Verified that the node-sass thing is really a Yarn issue. Applied workaround from yarnpkg/yarn#1981 and squashed this PR again.

[steven-ferguson]

I am still encountering #705 after upgrading to Ember 2.13.2

[bjornharrtell]

If that's the case it's unfortunate and unexpected. :( @steven-ferguson are you able to supply a test case?

[bjornharrtell]

Can reproduce it when running the Chips demo locally. Sorry for missing it before. Have noted this in glimmerjs/glimmer-vm#453.

[rwjblue]

If there are more scenarios that throw errors (missing implementation of x type things), please open issues for each over on the glimmer-vm repo with an example template snippet that triggers the error. I'm happy to dig in and fix the various cases that have been mentioned...

[bjornharrtell]

Remaining known regressions are now tracked by emberjs/ember.js#15258.

[bjornharrtell]

Upgraded to Ember 2.13.3 and can confirm the Chips demo now works without apparent issues. ❤️ @rwjblue. :)

[rwjblue]

Awesome, thank you for confirming!

[bjornharrtell]

@miguelcobain this should now be ready for review/merge.

[miguelcobain]

@bjornharrtell thanks a lot 👍