[bugfix] Chinese characters are chopped #227 #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, this PR does not totally fix the issue. because the space char after every Chinese char engage a cell. |
|
Thanks for the patch, I think this is a step in the right direction, but I need to rethink a bit this code. |
yes, I agree with you. And I read the iTerm2 source code, but it's really too complex, I'm searching for the NSAttributedString building logic in it's source code. |
… _count also inside the loop, follow up to fb1c3be
…ence that can do 11, 12 based on the number of arguments - this allows a single OSC call to set foreground, background and cursor in one go
…lication for steady vs blink, and the style of the cursor: block, underline or bar
…e view is removed from its superview, and when it comes back from the background
…ync cursor vs screen location
…ctive, and resume it when we become the first responder again; Also the out-of-focus cursor looked ugly, too thick, so make it thinner
… it is still missing the cursor adjustments and the panning handler is disabled for now, as it conflicts with the UIScrollView one
…roduced this regression in 1cb0245, fixes bug migueldeicaza#246
…l view, only install it when it is needed. This is necessary for the upcoming UIScrollView support
…ere with scrolling
…l view, only install it when it is needed. This is necessary for the upcoming UIScrollView support
…ld paint the top of the buffer
…on changes to the display, and instead it draws every time the contents from the primary data. Avoids the redraw bug entirely, but also, this cache is likely better somewhere else, without the cricularlist that might or might not be loaded
… are outside the sRGB color gamut. I clamp those values to the sRGB space for the terminal
…s the attrStrBuffer cache, which can get out of sync with the display needs. Removing this reduces some complexity, and also lets me tune separately some code later
Use weak ref to fix crash when process exits after view is released
migueldeicaza#294 It seems like the problem is the use of the convenience DispatchQueue read/write APIs that use a file descriptor as a parameter. They would stop delivering data even if data was avaialble, blocking the child process. I created a dedicated channel for reading and it works fine now (might consider doing this for writing to). Additionally, there is a new dispatchQueue introduced, this is not necessary to fix this particular bug, but while I was testing, I noticed a nicer scrolling behavior with a lot of output if I received the data on a queue, and then dispatched the results to the main queue than if I processed this directly in the main queue, which had a visual behavior of "waves".
…g for bar cursors
…actoring, this fixes migueldeicaza#306 and migueldeicaza#303
…Delegate open, so users can override these methods
…issues. See comment for details
…e bold logic here, fixes migueldeicaza#314
…for chWidth == 0, but other terminals are advancing even in the presence of a zero
…d ever happen after setting and limiting a font size between 5 and 72, but this prevents a crash
changes for visionos
…er assuming this is never nil
`inputAccessoryView` and `inputAssistantItem` are not available.
Fix visionOS build on latest beta SDK
the drawing is ok, but selection has some issues
…dy380743909/SwiftTerm into bugfix/issue_227_chinese_char_chopped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#227