Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid rendering of explicit forall in class instances #218

Closed
sheyll opened this issue Aug 25, 2016 · 1 comment
Closed

Invalid rendering of explicit forall in class instances #218

sheyll opened this issue Aug 25, 2016 · 1 comment

Comments

@sheyll
Copy link

sheyll commented Aug 25, 2016

Hello there,

Hindent is really important tool to me, I use it on a day-to-day basis, so thank you!

I can contribute awareness of small issue with the cramer formatter (Version 4.6.4).

online-example

instance forall x . C

is rendendered as

instance xC

which is clearly invalid syntax, and probably causes compile errors.

I have looked at the code in 4.6.4 as well as the master branch, I could not figure out whats going wrong there.

If I were to take a shot at it, in what branch do you recommend doing it? Is it planned to have bug-fixes in 4.6.4 or is all new development focussed on 5.x?

wbr Sven

@chrisdone
Copy link
Collaborator

This occurs in hindent 5 so I'll mark this as a bug and fix it, thanks!

If I were to take a shot at it, in what branch do you recommend doing it? Is it planned to have bug-fixes in 4.6.4 or is all new development focussed on 5.x?

I'd recommend using hindent 5 because that's where dev and improvements are going on in a (hopefully) general community direction. 😉 ☝️

But if you're married to the Cramer style, @gibiansky has said that he's maintaining hindent 4 here: https://github.com/gibiansky/hindent So I think you can contribute fixes there and use that version. 😄 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants