Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic discovery of MQTT credentials #10

Closed
1technophile opened this issue Oct 19, 2022 · 6 comments
Closed

Automatic discovery of MQTT credentials #10

1technophile opened this issue Oct 19, 2022 · 6 comments

Comments

@1technophile
Copy link
Collaborator

Hello,

I see that this addon:
https://github.com/mdegat01/addon-amr2mqtt/tree/main/amr2mqtt

Doesn't need to enter broker host and MQTT credentials. Do you think we could leverage the same principle per default?
And only use the host and credentials if they are set by the user.

@mihsu81
Copy link
Owner

mihsu81 commented Oct 20, 2022

Good find. I doubt I'll have time to start working on it before mid-December though.

@1technophile
Copy link
Collaborator Author

1technophile commented Oct 20, 2022

I suspect that we are only missing this:
https://github.com/mdegat01/addon-amr2mqtt/blob/8fdd816e98d74afd53aa2b958e38d86063c0af94/amr2mqtt/config.yaml#L18

here is the doc:
https://developers.home-assistant.io/docs/add-ons/configuration/

Thoughts?
I can do the modification and test.

@mihsu81
Copy link
Owner

mihsu81 commented Oct 20, 2022

I would say that - mqtt:want is not related, based on the documentation.
But try it if you want. I'm not an authority on the matter. 😁

@1technophile
Copy link
Collaborator Author

I confirm that - mqtt:want is not related.

@1technophile
Copy link
Collaborator Author

Just found that the RTL_433 addon doesn't need MQTT credentials also https://github.com/pbkhrv/rtl_433-hass-addons/blob/main/rtl_433/config.json

@mihsu81
Copy link
Owner

mihsu81 commented Aug 19, 2024

Added in https://github.com/mihsu81/addon-theengsgw/releases/tag/v1.11.4.
Thanks for the hints.

@mihsu81 mihsu81 closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants