Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to allow discovery? #10

Closed
anthonylavado opened this issue Jan 31, 2018 · 4 comments
Closed

Rename to allow discovery? #10

anthonylavado opened this issue Jan 31, 2018 · 4 comments

Comments

@anthonylavado
Copy link
Contributor

Hey @mike-grant! I've been following the activity on the v3 branch, and it looks like you've come a long way.

To help the discovery of this adapter once you've got it completed (or are willing to let most use it), have you considered renaming it?

Right now, as a fork, searching for haaska only reveals the original project. GitHub sort of "hides" forks behind the fork list. If you rename the project, the fork relationship will be removed, and you'll be discoverable as a result.

@mike-grant
Copy link
Owner

That v3 branch is mainly ready to go, i've just been taking my time to update the documentation. There's a few things left to decide what to do as well. Most of the action are undertaken directly in HA thanks to someone elses work to expose it. But not everything I want to support is supported within HA currently.

With regards to renaming it, it's not something I had contemplated yet. I originally tried reaching out to @auchter but didn't get anywhere with that, and that's how I had left it. I'll give it some thought over the next couple of days what to do with renaming it.

Thanks!

@mike-grant
Copy link
Owner

@anthonylavado I've had this repo seperated from the fork which allows it to be found via the search now. Saves me having to rename it ;)

@cbrherms
Copy link

cbrherms commented Feb 1, 2018

It probably would be better renaming though for the majority of users. Even if it is just like haaska V3

@anthonylavado
Copy link
Contributor Author

A simple change like that might not be a bad idea. Then we could submit something against the recent change to the docs: home-assistant/home-assistant.io#4493

and switch it out to your repo (once everything is cleaned up and merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants