-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrading to 3.0, the performance is greatly reduced #51
Comments
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Webworkers are indeed slower. In my benchmark repository I had code to run the benchmarks in webworkers, a while back, and found they ran only half as quick as in the main thread. Not sure what I could do about it. |
@DuShuYuan In the attached code you used STANDARD as input, but your report is about DUITL, right? I'm asking because the STANDARD input needs forever to lex. I stopped the test after a couple of minutes. When I limit the STANDARD input to the first 66 lines (576 tokens) it takes a bit more than 4 seconds to do a cold lexer run. DUTIL is lexed in 4.6 seconds for me (618 tokens). So, that seems to be in the range you expect, correct? Can you try with the latest release again and compare that? |
demo with webworker: |
Hmm, so version 3.0 is twice as fast (12s vs 26s). Isn't that the opposite of what you report above? |
In WebWorker 2.0 is faster (6s), Target 2015 even takes less than 3s |
I think the most common use case is in webworkers. You can take a look at the output of this demo. |
Have you tried recently to build with a newer packager version? I can imagine that older ones do not use latest ES6 features like private |
When running in WebWorder, it takes about 4 seconds to parse the same SQL statement (Oracle) in version 2.0 and about 15 seconds in version 3.0
My code:
SQL statement tested: ORACLE's package SYS. DIUTIL
If a larger SQL is larger, the webworker will be automatically stopped, and the webwoker will be automatically recycled when it resolves to about 18,000 tokens in 2.0, and can only be resolved to 5,000 tokens in 3.0
I feel that the 3.0 version of the token will take up more memory
SQL statement tested: ORACLE's package SYS. STANDARD
The text was updated successfully, but these errors were encountered: