Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload Table if error occurred #1

Open
markst opened this issue Oct 16, 2018 · 2 comments
Open

Reload Table if error occurred #1

markst opened this issue Oct 16, 2018 · 2 comments

Comments

@markst
Copy link

markst commented Oct 16, 2018

Currently error handling silently fails:
https://github.com/mikeRozen/MRDropDown/blob/master/MRDropDown/MRDropDown.swift#L356

I'd like to be able to handle the error responses, or at least reload the results to display nothing...
@markst
Copy link
Author

markst commented Oct 16, 2018

Ah apologies I just found the MRTextFieldDelegate function!

I might still make a PR to reload results if an error has occurred.

@markst markst changed the title Error handling Reload Table if error occured Oct 17, 2018
@markst markst changed the title Reload Table if error occured Reload Table if error occurred Oct 17, 2018
@mikeRozen
Copy link
Owner

When you receive an error, I still keep the data from the previous response so even if you do the reload you will see the old results. (as far as I remember)
I would say its better to show the user his previous search results even though he received an error for some request. (I am not sure if it wise to show an empty table view if suddenly one of the requests failed ).
But maybe I miss your goal, so explain the behavior you want to achieve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markst @mikeRozen