Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walk calls back early if the last entry is a directory #42

Closed
jdknezek opened this issue Apr 8, 2013 · 1 comment · Fixed by #43
Closed

walk calls back early if the last entry is a directory #42

jdknezek opened this issue Apr 8, 2013 · 1 comment · Fixed by #43

Comments

@jdknezek
Copy link
Contributor

jdknezek commented Apr 8, 2013

walk is calling back multiple times if the final entry in a directory is itself a directory.

On this line callback.pending will be incremented, but the value of done is not updated before calling back.
@jdknezek jdknezek mentioned this issue Apr 8, 2013
Merged
@SpeCT
Copy link

SpeCT commented Apr 23, 2013

+1 for the fix. Thanks Jonathan. 👍

@jdknezek jdknezek closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Issue 42
2 participants
@jdknezek @SpeCT