Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function stop watching #53

Closed
amasad opened this issue May 18, 2014 · 1 comment
Closed

function stop watching #53

amasad opened this issue May 18, 2014 · 1 comment

Comments

@amasad
Copy link
Collaborator

amasad commented May 18, 2014

Right now the only way to stop watching the files is to kill the process (or manually traverse files and unwatch). unwatchTree, and/or monitor.stop functions to stop watching the files.

I want to send a PR to implement that but I see there are a few stale pull requests so before I write any code is that something you'll be interested in merging?
@mikeal
Copy link
Owner

mikeal commented May 19, 2014

if you write it i'll merge it and add you as a collaborator since I am clearly failing at staying on top of PRs :)

amasad added a commit to amasad/watch that referenced this issue May 19, 2014
@amasad
Implement unwatchTree, and monitor.stop. Fixes mikeal#53
b2a7313
@mikeal mikeal closed this as completed in 69094f6 May 20, 2014
mikeal added a commit that referenced this issue May 20, 2014
@mikeal
Merge pull request #54 from amasad/master
9f30332 
Implement unwatchTree, and monitor.stop. Fixes #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeal @amasad