Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we break out the part that does the calculations? #6

Closed
keanfreeman opened this issue Apr 1, 2020 · 2 comments
Closed

Can we break out the part that does the calculations? #6

keanfreeman opened this issue Apr 1, 2020 · 2 comments

Comments

@keanfreeman
Copy link

In another project, we’re using the chunk of code in scripts.js above the jQuery that does the actual predictions (generate_possibilities and everything it depends on). We’re generating a google sheet instead of HTML. It’d be nice if the prediction code was separate from the code that generates the HTML.

I was thinking the best way would be to move the code into another git repository and include it in this one as a sub module. That way your website is independent of the code that generates the predictions (would be nice for our project). Also we could make an npm package potentially.

Let me know what you think 😊

@jyh947
Copy link

jyh947 commented Apr 1, 2020

Hey just a heads up, my friend and I forked from mikebryant's code and already finished the Google Sheets integration. Check it out here:

https://github.com/drfuzzyness/google-sheets-stalk-market-calculator

Get your own copy of the Google Sheets here:

https://docs.google.com/spreadsheets/d/1EqQIjfD-WeDWVBNqk2I_CXjmZtGhTP7LbqZxCT5EAtM/copy

@mikebryant
Copy link
Owner

I've moved it to a separate file, so you can load it via a standard <script> tag etc :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants