Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to honor bindingRedirect in App.config / Web.config #54

Closed
pfeigl opened this issue Sep 25, 2018 · 3 comments
Closed

Option to honor bindingRedirect in App.config / Web.config #54

pfeigl opened this issue Sep 25, 2018 · 3 comments

Comments

@pfeigl
Copy link
Contributor

pfeigl commented Sep 25, 2018

We are using AsmSpy as part of our build process to make sure we didn't miss out adding important references.

One thing we often run into is version mismatches which we actually fixed using bindingRedirects, but AsmSpy is still reporting them.

Is it possible to extend AsmSpy to honor bindingRedirects?
@mikehadlow
Copy link
Owner

Hi Philipp,
That's a good idea. I don't have time to implement it right now, but I'd be more than happy if you wanted to submit a pull request.
Thanks,
Mike

pfeigl added a commit to pfeigl/AsmSpy that referenced this issue Sep 25, 2018
@pfeigl
feat(binding-redirect): add option to allow binding redirects via pro…
182c098 
…vided configuration file (mikehadlow#54)
@pfeigl
Copy link
Contributor Author

pfeigl commented Sep 26, 2018

Sent a PR btw for this :)

@pfeigl pfeigl mentioned this issue Sep 26, 2018
Merged
@pfeigl
Copy link
Contributor Author

pfeigl commented Sep 26, 2018

This should btw also close #7, because this seems to be still open because of the required check for the binding redirects

mikehadlow added a commit that referenced this issue Sep 26, 2018
@mikehadlow
Merge pull request #55 from pfeigl/pfeigl_master
50115a6 
feat(binding-redirect): add option to allow binding redirects via provided configuration file (#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikehadlow @pfeigl