Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

mail 2.3.0 has test failures with ruby 1.9.3 #318

Closed
graaff opened this Issue Dec 29, 2011 · 3 comments

Comments

Projects
None yet
3 participants

graaff commented Dec 29, 2011

I'm getting the following test failures when running the tests with ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-linux]

1)
'Mail::ContentTypeField finding a filename should encode a non us-ascii filename' FAILED
expected: "Content-Type: application/octet-stream;\r\n filename*=shift_jis'jp'01%20Quien%20Te%20Dij%91%61t.%20Pitbull.mp3\r\n",
     got: "Content-Type: application/octet-stream;\r\n filename*=windows-31j'jp'01%20Quien%20Te%20Dij%91%61t.%20Pitbull.mp3\r\n" (using ==)

 Diff:
@@ -1,3 +1,3 @@
 Content-Type: application/octet-stream;
- filename*=shift_jis'jp'01%20Quien%20Te%20Dij%91%61t.%20Pitbull.mp3
+ filename*=windows-31j'jp'01%20Quien%20Te%20Dij%91%61t.%20Pitbull.mp3

/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/expectations/fail_with.rb:41:in `fail_with'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/matchers/operator_matcher.rb:44:in `fail_with_message'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/matchers/operator_matcher.rb:66:in `__delegate_operator'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/matchers/operator_matcher.rb:56:in `eval_match'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/matchers/operator_matcher.rb:34:in `block in use_custom_matcher_or_delegate'
/home/graaff/playground/github-clones/mail/spec/mail/fields/content_type_field_spec.rb:627:in `block (3 levels) in <top (required)>'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_methods.rb:40:in `instance_eval'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_methods.rb:40:in `block in execute'
/usr/lib64/ruby/1.9.1/timeout.rb:54:in `timeout'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_methods.rb:37:in `execute'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_group_methods.rb:219:in `block in run_examples'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_group_methods.rb:217:in `each'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_group_methods.rb:217:in `run_examples'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_group_methods.rb:103:in `run'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:23:in `block in run'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:22:in `each'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:22:in `run'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/options.rb:153:in `run_examples'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/command_line.rb:9:in `run'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/bin/spec:5:in `<main>'

2)
'PartsList should return itself on sort' FAILED
expected: Mail::PartsList,
     got: Array (using ==)

 Diff:
@@ -1,2 +1,2 @@
-Mail::PartsList
+Array

/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/expectations/fail_with.rb:41:in `fail_with'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/matchers/operator_matcher.rb:44:in `fail_with_message'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/matchers/operator_matcher.rb:66:in `__delegate_operator'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/matchers/operator_matcher.rb:56:in `eval_match'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/matchers/operator_matcher.rb:34:in `block in use_custom_matcher_or_delegate'
/home/graaff/playground/github-clones/mail/spec/mail/parts_list_spec.rb:10:in `block (2 levels) in <top (required)>'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_methods.rb:40:in `instance_eval'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_methods.rb:40:in `block in execute'
/usr/lib64/ruby/1.9.1/timeout.rb:54:in `timeout'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_methods.rb:37:in `execute'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_group_methods.rb:219:in `block in run_examples'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_group_methods.rb:217:in `each'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_group_methods.rb:217:in `run_examples'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/example/example_group_methods.rb:103:in `run'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:23:in `block in run'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:22:in `each'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/example_group_runner.rb:22:in `run'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/options.rb:153:in `run_examples'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/lib/spec/runner/command_line.rb:9:in `run'
/usr/lib64/ruby/gems/1.9.1/gems/rspec-1.3.2/bin/spec:5:in `<main>'
Contributor

voxik commented Jan 31, 2012

The first looks to be fixed by 25801d4

Contributor

voxik commented Jan 31, 2012

The second is fixed by d88fa14 . It seems this issue could be closed.

Collaborator

arunagw commented Mar 24, 2012

thanks guys! mail gem build is green now. http://travis-ci.org/#!/mikel/mail

@arunagw arunagw closed this Mar 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment