Reduce warnings "mismatched indentations" on ruby 2.6 #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rake v12.1.0 or higher, the algorithm of resolve file dependency was changed in ruby/rake#39 . Then rake task "ragel:generate" is works incorrectry that require wrong ragel source file. As the example, rake resolves "lib/mail/parsers/address_lists_parser.rb" needs "lib/mail/parsers/address_lists.rl", but this file is not exist. Therefore, fixed that to pass full path of the ragel source file to rule.
file -- bundler/dep_proxy` ```ruby bundle exec rake bundler: failed to load command: rake (/home/travis/build/mikel/mail/vendor/bundle/ruby/2.5.0/bin/rake) LoadError: cannot load such file -- bundler/dep_proxy ```
show warning messages from ruby on ci
Suppress warning message that enabled from ruby 2.6 .
To format ruby files generated by ragel.
To suppress warning messages from ruby "mismatched indentations at 'when' with 'case'" .
unasuke
force-pushed
the
reduce_warnings_on_ruby_2_6
branch
from
197ecc3
to
6a246bc
Compare
jeremy
approved these changes
Apr 13, 2018
|
@jeremy Thank you!!!l 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
In Ruby 2.6 with option "-w", introduce warning message "mismatched indentations" by following case-when syntax.
Fix to like this, warning message suppressed.
why
In some gem's test (that dependent to mail.gem) with "-w" option, output a ton of warning messages that makes test slow and hard to see the test results.
e.g. https://travis-ci.org/rails/rails/jobs/365674633
I know that this issue comes from auto generated ruby codes by ragel.
So "real fix" of this issue is making a patch to ragel (also I know!)
But...but, ragel is written in C. I couldn't fix the indentation issue.
Therefore, I add rufo gem as the development dependency and format in rake task to fix wrong (from ruby 2.6) case-when indents.
unsolved
Can't fix by using rufo in some case of warning messages.
statement not reachedassigned but unused variable