Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quoted printable Fixes #1241 #1246

Closed
wants to merge 5 commits into from
Closed

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Jul 6, 2018

Works, kind of, but I don't think this is the correct fix. Probably we need a custom pack?

see #1241

@ahorek ahorek changed the title WIP: quoted printable Fixes #1241 quoted printable Fixes #1241 Jul 6, 2018
jfelchner added a commit to big-wheelbarrow/mail that referenced this pull request Aug 23, 2018
------------------------------------------------------------------------
Github Issue URLs:
  * mikel#1246
  * mikel#1241
@oniram88
Copy link

direct merge of this branch in master works great!

@ahorek
Copy link
Contributor Author

ahorek commented Jan 21, 2019

@oniram88
thanks for testing, but this isn't safe to use in production. Even it it would probably work, it violates RFC
https://www.ietf.org/rfc/rfc2045.txt

especially this one

(Soft Line Breaks) The Quoted-Printable encoding
          REQUIRES that encoded lines be no more than 76
          characters long.  If longer lines are to be encoded
          with the Quoted-Printable encoding, "soft" line breaks
          must be used.  An equal sign as the last character on a
          encoded line indicates such a non-significant ("soft")
          line break in the encoded text.

   Thus if the "raw" form of the line is a single unencoded line that
   says:

     Now's the time for all folk to come to the aid of their country.

   This can be represented, in the Quoted-Printable encoding, as:

     Now's the time =
     for all folk to come=
      to the aid of their country.

   This provides a mechanism with which long lines are encoded in such a
   way as to be restored by the user agent.  The 76 character limit does
   not count the trailing CRLF, but counts all other characters,
   including any equal signs.

I'm looking for feedback from @jeremy or someone else who knows Quoted-Printable better than me.

If you have ideas or a different approach how to fix it, give me a comment. I may take a look at it again. But right now, I don't know how to proceed with this...

@ahorek
Copy link
Contributor Author

ahorek commented Feb 14, 2020

I don't think this change is 100% correct and there's no response for more than a year, closing

@ahorek ahorek closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants