Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I select an item and reopen the drawer with sticky Header, spaces appear next to the items #2689

Closed
6 tasks done
ciansanz opened this issue Dec 11, 2020 · 8 comments · Fixed by #2691 or #2694
Closed
6 tasks done
Assignees

Comments

@ciansanz
Copy link

ciansanz commented Dec 11, 2020

About this issue

  • Hi, I am starting a new project, I implement the Drawer with a header using stickyHeaderView. At this point when I start the app I see that a space appears between the header and the first item and also that only when I select an item and reopen the drawer do spaces appear next to the items, as shown in the image.

Details

  • [8.2.0 ] Used library version
  • [4.0.1] Used gradle build tools version

3333315

ddddd3

Checklist

@mikepenz
Copy link
Owner

@cristhian-sn is this problem reproducible in the sample app?

@mikepenz mikepenz self-assigned this Dec 14, 2020
@ciansanz
Copy link
Author

Yes, I put a sticky header in sample app and..
cap2

@DetroitSmash313
Copy link

DetroitSmash313 commented Dec 17, 2020

I can confirm, I'm facing the same issue, that only happens when the sticky header is used.
val headerItem = layoutInflater.inflate(R.layout.nav_header, null)
drawer.stickyHeaderView = headerItem

mikepenz added a commit that referenced this issue Dec 18, 2020
  - FIX #2689
- ensure to not apply unnecessary padding on top if a sticky header or sticky footer is used
- showcase sticky header in sample
@ciansanz
Copy link
Author

@mikepenz Hi, the 8.3.0 release fixes the problem with the padding top, but I have tried the sample app in this version and the problem with the shadow is still there, maybe it is not appreciated because of the dark theme but it is there. As I mentioned earlier this is only seen when you open and close the drawer. You can better appreciate it with a light theme.

@mikepenz
Copy link
Owner

@cristhian-sn I checked it with light theme actually on a Pixel 5 with Android 11 but didn't see it anymore then :/

I could reproduce it first but afterwards it would be fine. Will give it another pair of eyes. :/

@ciansanz
Copy link
Author

@mikepenz Maybe the android version :d ? I have seen it in android 9 and 10. I will check it in android 11 ..

@ciansanz
Copy link
Author

@mikepenz I test it on an emulator with android 11 and the shadow keeps appearing :(
Screenshot_1608310747d

@mikepenz
Copy link
Owner

well must have been lucky then :D will give it another look. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants