Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadow with sticky header #2691

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix shadow with sticky header #2691

merged 1 commit into from
Dec 18, 2020

Conversation

mikepenz
Copy link
Owner

@mikepenz
- fix elevation shadow with sticky header
2afa22e 
  - FIX #2689
- ensure to not apply unnecessary padding on top if a sticky header or sticky footer is used
- showcase sticky header in sample
@mikepenz mikepenz added the fix label Dec 18, 2020
github-actions[bot]
github-actions bot reviewed Dec 18, 2020
View reviewed changes
app/src/main/java/com/mikepenz/materialdrawer/app/MultiDrawerActivity.kt
@@ -62,6 +62,7 @@ class MultiDrawerActivity : AppCompatActivity() {
}

binding.sliderEnd.apply {
stickyHeaderView = layoutInflater.inflate(R.layout.header, null)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout’s root element)

@mikepenz mikepenz merged commit e160110 into develop Dec 18, 2020
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When I select an item and reopen the drawer with sticky Header, spaces appear next to the items
1 participant
@mikepenz