enhancement: link clickable span detection #129
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I am using your library in my Lemmy client and I really like it (lightweight, easy to use, extensible, multiplatform to the core, perfect MD integration, etc.). Kudos!
My users reported the following bug: if there is a link inside a text node, the whole line is clickable and opens it even if the tapped position exceeds the anchor text length, i. e. provided that the tap event occurs in the same line after the link, the link is opened anyways.
Steps to reproduce: in the example application change the last two lines of the sample text like this
The solution was a little more difficult than expected, because the LINK_DEFINITION node handler is not called for autolinks or links inside a text node, but just for internal Markdown references, so I had to modify even the text handlers. Another "weird" behaviour which I found is that annotations are added multiple times for the same reference, which was somehow "hidden" by the
reversed().firstOrNull()
access to the list, but the test on the hit rect against the annotation position had to be improved.