Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue parsing dependencies #79

Closed
yocontra opened this issue Oct 16, 2012 · 3 comments
Closed

Issue parsing dependencies #79

yocontra opened this issue Oct 16, 2012 · 3 comments

Comments

@yocontra
Copy link
Contributor

This is after #78 has been applied (haven't tested if it is a bug with vanilla)

<div data-show=":​completed | length | overZero < .items">

yields

options = {
  bypass: true
  formatters: ["length", "overZero < .items"]
}

when it should be

options = {
  bypass: true
  formatters: ["length", "overZero"]
  dependencies: [".items"]
}
@msheakoski
Copy link

I'm not sure how dependencies currently work with formatters, but shouldn't it be more like:

<div data-show=":​completed < .items | length | overZero">

The dependency should be linked to the bypassed method, and then the formatters deal with the changed value.

@yocontra
Copy link
Contributor Author

Well this fixed my problem... I feel stupid now. Maybe some documentation on the order/combining these two features would help others

@msheakoski
Copy link

If you have a chance to make a PR for this, I'm sure it will be merged in. If I have time later this week and you haven't gotten around to it yet, I will see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants